[Devel] Re: [PATCH] remove BUG() in possible but rare condition

Linus Torvalds torvalds at linux-foundation.org
Wed Apr 11 11:57:56 PDT 2012


On Wed, Apr 11, 2012 at 11:48 AM, Michal Hocko <mhocko at suse.cz> wrote:
>
> I am not familiar with the code much but a trivial call chain walk up to
> write_dev_supers (in btrfs) shows that we do not check for the return value
> from __getblk so we would nullptr and there might be more.
> I guess these need some treat before the BUG might be removed, right?

Well, realistically, isn't BUG() as bad as a NULL pointer dereference?

Do you care about the exact message on the screen when your machine dies?

                     Linus




More information about the Devel mailing list