[Devel] Re: [PATCH 4/8] nfsd: use exp_put() for svc_export_cache put

Stanislav Kinsbursky skinsbursky at parallels.com
Wed Apr 11 07:41:39 PDT 2012


11.04.2012 18:16, J. Bruce Fields пишет:
> On Wed, Mar 28, 2012 at 07:09:22PM +0400, Stanislav Kinsbursky wrote:
>> This patch replaces cache_put() call for svc_export_cache by exp_put() call.
>
> Patch looks fine.  Minor peeve: the changelog doesn't tell me anything I
> couldn't figure out immediately from reading the patch.  Tell me *why*
> we're doing this ("Removing another hard-coded svc_export_cache will
> simplify adding per-export caches later"), or if it's really totally
> obvious I'd rather have an empty changelog than a useless one....
>

Ok, will do so for further patches.

-- 
Best regards,
Stanislav Kinsbursky




More information about the Devel mailing list