[Devel] Re: [PATCH v2] usbnet: fix oops in usbnet_start_xmit

David Miller davem at davemloft.net
Mon Nov 7 10:26:55 PST 2011


From: Richard Cochran <richardcochran at gmail.com>
Date: Mon, 7 Nov 2011 18:39:19 +0100

> On Mon, Nov 07, 2011 at 06:54:58PM +0300, Konstantin Khlebnikov wrote:
>> This patch fixes the bug added in commit v3.1-rc7-1055-gf9b491e
>> SKB can be NULL at this point, at least for cdc-ncm.
>> 
>> Signed-off-by: Konstantin Khlebnikov <khlebnikov at openvz.org>
> 
> Acked-by: Richard Cochran <richardcochran at gmail.com>

Applied, but the overall logic in the usbnet transmit path definitely
could use a good reconsideration and cleanup.

I'm even open to having generic support at the generic net device TX
level to fixup the segmentation layout of the SKB so that it meets
the device's requirements.  We can do it more efficiently there too.




More information about the Devel mailing list