[Devel] Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines

[Peng Tao]

On Tue, Nov 29, 2011 at 9:35 PM, Myklebust, Trond
<Trond.Myklebust at netapp.com> wrote:
>> -----Original Message-----
>> From: tao.peng at emc.com [mailto:tao.peng at emc.com]
>> Sent: Tuesday, November 29, 2011 7:40 AM
>> To: skinsbursky at parallels.com
>> Cc: Myklebust, Trond; linux-nfs at vger.kernel.org; xemul at parallels.com;
>> neilb at suse.de; netdev at vger.kernel.org; linux-kernel at vger.kernel.org;
>> jbottomley at parallels.com; bfields at fieldses.org; davem at davemloft.net;
>> devel at openvz.org
>> Subject: RE: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference
>> from blocklayout routines
>>
>> > -----Original Message-----
>> > From: Stanislav Kinsbursky [mailto:skinsbursky at parallels.com]
>> > Sent: Tuesday, November 29, 2011 8:19 PM
>> > To: Peng, Tao
>> > Cc: Trond.Myklebust at netapp.com; linux-nfs at vger.kernel.org; Pavel
>> > Emelianov; neilb at suse.de; netdev at vger.kernel.org;
>> > linux-kernel at vger.kernel.org; James Bottomley; bfields at fieldses.org;
>> > davem at davemloft.net; devel at openvz.org
>> > Subject: Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference
>> > from blocklayout routines
>> >
>> > 29.11.2011 16:00, tao.peng at emc.com пишет:
>> > >> -----Original Message-----
>> > >> From: linux-nfs-owner at vger.kernel.org
>> > >> [mailto:linux-nfs-owner at vger.kernel.org] On Behalf Of
>> > Stanislav
>> > >> Kinsbursky
>> > >> Sent: Tuesday, November 29, 2011 6:11 PM
>> > >> To: Trond.Myklebust at netapp.com
>> > >> Cc: linux-nfs at vger.kernel.org; xemul at parallels.com; neilb at suse.de;
>> > >> netdev at vger.kernel.org; linux- kernel at vger.kernel.org;
>> > >> jbottomley at parallels.com; bfields at fieldses.org;
>> > >> davem at davemloft.net; devel at openvz.org
>> > >> Subject: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference
>> > >> from blocklayout routines
>> > >>
>> > >> This is a cleanup patch. We don't need this reference anymore,
>> > >> because blocklayout pipes dentries now creates and destroys in
>> > >> per-net operations and on PipeFS mount/umount notification.
>> > >> Note that nfs4blocklayout_register_net() now returns 0 instead of
>> > >> -ENOENT in case of PipeFS superblock absence. This is ok, because
>> > >> blocklayout pipe dentry will be created on PipeFS mount event.
>> > > When is the "pipefs mount event" going to happen? When inserting
>> > > kernel modules or when user issues
>> > mount command?
>> > >
>> >
>> > When user issues mount command.
>> > Kernel mounts of PipeFS has been removed with all these patch sets
>> > I've sent already.
>> Then it is going to break blocklayout user space program blkmapd, which is
>> stared before mounting any file system and it tries to open the pipe file
>> when started.
>
> Why on earth is blkmapd doing this instead of listening for file creation notifications like the other rpc_pipefs daemons do?
Not sure how the original implementer chose this but I think it is
likely because we do not expect the pipe file to be created or deleted
dynamically.

-- 
Thanks,
Tao