[Devel] Re: [PATCH] perf: add ability to record event period

Arnaldo Carvalho de Melo acme at infradead.org
Tue Dec 20 09:20:19 PST 2011


Em Tue, Dec 20, 2011 at 05:32:45PM +0300, Andrew Vagin escreveu:
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 766fa0a..f8fd14f 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -700,6 +700,7 @@ const struct option record_options[] = {
>  	OPT_BOOLEAN('d', "data", &record.opts.sample_address,
>  		    "Sample addresses"),
>  	OPT_BOOLEAN('T', "timestamp", &record.opts.sample_time, "Sample timestamps"),
> +	OPT_BOOLEAN('P', "period", &record.opts.period, "Sample period"),
>  	OPT_BOOLEAN('n', "no-samples", &record.opts.no_samples,
>  		    "don't sample"),
>  	OPT_BOOLEAN('N', "no-buildid-cache", &record.no_buildid_cache,

You forgot to update the tools/perf/Documentation/perf-record.txt tho.

I'm doing this for you this time, please take that into account next
time.

Regards and thanks for iterating thru this and working on perf!

- Arnaldo




More information about the Devel mailing list