[Devel] Re: [PATCH 2/3] make clone_children a flag

Glauber Costa glommer at parallels.com
Wed Dec 14 23:03:38 PST 2011


On 12/14/2011 10:18 PM, Tejun Heo wrote:
> Hello,
>
> On Wed, Dec 14, 2011 at 11:09:14AM +0400, Glauber Costa wrote:
>> That's indeed confusing, and it comes from the fact that we always
>> inherit clone_children from the parent - which is sane, IMHO. So
>> this flag only has any value in establishing the initial behaviour
>> of the top root cgroup. I wonder then if it wouldn't better to just
>> be explicit and fail in this case ?
>
> I don't think all current behaviors are sane and if not let's change
> them, but those things have to be explicit with proper description and
> rationale.
>

140 % agree to that. As I said, I wrongly believed it to be functionally 
equivalent when I sent it, but missed the flags remount check.

If you believe the behavior we now get is saner, I can rewrite the 
Changelog and resend it.




More information about the Devel mailing list