[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

Paul Menage menage at google.com
Tue Sep 7 13:26:48 PDT 2010


On Tue, Sep 7, 2010 at 1:23 PM, Daniel Lezcano <daniel.lezcano at free.fr> wrote:
>> This bit is awkward - you're storing the original value of the
>> clone_children flag to report in the mount options, but this isn't
>> necessarily the current state. Might it be better to not store this
>> and just report the current value of the root cgroup's
>> CGRP_CLONE_CHILDREN flag?
>>
>
> Sure. Shall I do the same as the release agent mount option ?

I think so - the slight problem with this new flag is that it's
possible for the root cgroup to have one setting for clone_children
and all its children to have a different setting. But I guess we can
live with that. (Or maybe simply not make the default clone_children
value a mount option, but require it to be set on the root cgroup
after mounting?)

Paul
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list