[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

[Paul Menage]

On Sat, Sep 4, 2010 at 12:31 AM, Daniel Lezcano <daniel.lezcano at free.fr> wrote:
> @@ -229,6 +229,7 @@ inline int cgroup_is_removed(const struct cgroup *cgrp)
>  /* bits in struct cgroupfs_root flags field */
>  enum {
>        ROOT_NOPREFIX, /* mounted subsystems have no named prefix */
> +       ROOT_CLONE_CHILDREN, /* mounted subsystems will inherit from parent */
>  };

This bit is awkward - you're storing the original value of the
clone_children flag to report in the mount options, but this isn't
necessarily the current state. Might it be better to not store this
and just report the current value of the root cgroup's
CGRP_CLONE_CHILDREN flag?

Paul
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers