[Devel] Re: [PATCH 03/11] checkpoint: reformat CKPT_VMA_NOT_SUPPORTED

[Matt Helsley]

On Wed, Oct 20, 2010 at 01:56:38PM -0500, Nathan Lynch wrote:
> Remove duplicate VM_HUGETLB and VM_NONLINEAR; place each flag on its
> own line and alphabetize the list.  This will make future
> modifications to CKPT_VMA_NOT_SUPPORTED easier to review.
> 
> Signed-off-by: Nathan Lynch <ntl at pobox.com>

Reviewed-by: Matt Helsley <matthltc at us.ibm.com>

> ---
>  include/linux/checkpoint.h |   15 +++++++++++----
>  1 files changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h
> index a11d40e..49cf01e 100644
> --- a/include/linux/checkpoint.h
> +++ b/include/linux/checkpoint.h
> @@ -309,10 +309,17 @@ extern int checkpoint_memory_contents(struct ckpt_ctx *ctx,
>  extern int restore_memory_contents(struct ckpt_ctx *ctx, struct inode *inode);
> 
> 
> -#define CKPT_VMA_NOT_SUPPORTED						\
> -	(VM_IO | VM_HUGETLB | VM_NONLINEAR | VM_PFNMAP |		\
> -	 VM_RESERVED | VM_HUGETLB | VM_NONLINEAR |	\
> -	 VM_MAPPED_COPY | VM_INSERTPAGE | VM_MIXEDMAP | VM_SAO)
> +#define CKPT_VMA_NOT_SUPPORTED (			\
> +		VM_HUGETLB |				\
> +		VM_INSERTPAGE |				\
> +		VM_IO |					\
> +		VM_MAPPED_COPY |			\
> +		VM_MIXEDMAP |				\
> +		VM_NONLINEAR |				\
> +		VM_PFNMAP |				\
> +		VM_RESERVED |				\
> +		VM_SAO |				\
> +		0)
> 
>  /* signals */
>  extern int checkpoint_obj_sighand(struct ckpt_ctx *ctx, struct task_struct *t);
> -- 
> 1.7.2.2
> 
> _______________________________________________
> Containers mailing list
> Containers at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers