[Devel] Re: [PATCH v4] memcg: reduce lock time at move charge

[Daisuke Nishimura]

On Tue, 12 Oct 2010 14:48:01 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu at jp.fujitsu.com> wrote:

> On Tue, 12 Oct 2010 12:56:13 +0900
> Daisuke Nishimura <nishimura at mxp.nes.nec.co.jp> wrote:
> 
> > > +err_out:
> > > +	for (; mt < info + num; mt++)
> > > +		if (mt->type == MC_TARGET_PAGE) {
> > > +			putback_lru_page(mt->val.page);
> > Is this putback_lru_page() necessary ?
> > is_target_pte_for_mc() doesn't isolate the page.
> > 
> Ok, v4 here. tested failure path and success path.
> 
Looks good to me.

	Acked-by: Daisuke Nishimura <nishimura at mxp.nes.nec.co.jp>

Thanks,
Daisuke Nishimura.
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers