[Devel] Re: [PATCH] Clear the objhash before completing restart, but delay free (v2)

[Dan Smith]

OL> Does this patch solve the performance problem in freeing all
OL> the objhash entries upfront (e.g. before letting userspace
OL> resume) ?

OL> If so, is there still a performance hit for doing the 'clear'
OL> portion early before resuming the tasks ?   How much does it
OL> depend on the complexity of the hierarchy being checkpointed ?

I've actually been unable to detect any real different in performance
between this and the way it was before.  I've run it against several
different large checkpoints (multiple processes, with sockets, IPC,
many files open, etc).  I have another option for the functionality,
which is to mark only specific items as needing to be free()'d early,
but I can't discern a difference between that or this option either.
What I can discern is that this patch is more likely to prevent
similar issues in the future by making the behavior of the hash far
more generally correct, IMHO.

-- 
Dan Smith
IBM Linux Technology Center
email: danms at us.ibm.com
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers