[Devel] Re: [PATCH v21 053/100] c/r (ipc): allow allocation of a desired ipc identifier

Oren Laadan orenl at cs.columbia.edu
Fri May 7 10:08:17 PDT 2010



Manfred Spraul wrote:
> Hi Oren,
> 
> 
> On 05/01/2010 04:15 PM, Oren Laadan wrote:
>> @@ -82,7 +82,7 @@ void shm_init_ns(struct ipc_namespace *ns)
>>    * Called with shm_ids.rw_mutex (writer) and the shp structure locked.
>>    * Only shm_ids.rw_mutex remains locked on exit.
>>    */
>> -static void do_shm_rmid(struct ipc_namespace *ns, struct 
>> kern_ipc_perm *ipcp)
>> +void do_shm_rmid(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)
>>   {
>>       struct shmid_kernel *shp;
>>       shp = container_of(ipcp, struct shmid_kernel, shm_perm);
>>    
> This hunk appears to be unrelated to the main patch.
> Is it intentional or a left-over from debugging?
> 

Good catch: it belongs in patch 55: "c/r: support shared memory 
sysv-ipc". Will move it there. Thanks for the review.

Oren.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list