[Devel] Re: [PATCH 1/2] Fix app_checkpoint() return code
Oren Laadan
orenl at cs.columbia.edu
Wed Mar 31 21:59:45 PDT 2010
Both patches applies in user-cr:ckpt-v20-dev.
Oren.
Sukadev Bhattiprolu wrote:
> From: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
> Date: Tue, 30 Mar 2010 18:59:10 -0700
> Subject: [PATCH 1/2] Fix app_checkpoint() return code
>
> Have app_checkpoint() return the return value from the system call
> so callers find some useful information. Have main() can convert the
> return value into a suitable exit status.
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
> ---
> checkpoint-main.c | 4 +++-
> checkpoint.c | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/checkpoint-main.c b/checkpoint-main.c
> index f6faa32..bac65cc 100644
> --- a/checkpoint-main.c
> +++ b/checkpoint-main.c
> @@ -145,6 +145,7 @@ static void parse_args(struct app_checkpoint_args *args, int argc, char *argv[])
>
> int main(int argc, char *argv[])
> {
> + int ret;
> struct app_checkpoint_args args;
> unsigned long flags = 0;
> pid_t pid;
> @@ -167,5 +168,6 @@ int main(int argc, char *argv[])
> if (!args.container)
> flags |= CHECKPOINT_SUBTREE;
>
> - return app_checkpoint(pid, flags, &args);
> + ret = app_checkpoint(pid, flags, &args);
> + return (ret > 0) ? 0 : 1;
> }
> diff --git a/checkpoint.c b/checkpoint.c
> index e3a1ce8..e0290c9 100644
> --- a/checkpoint.c
> +++ b/checkpoint.c
> @@ -55,5 +55,5 @@ int app_checkpoint(int pid, unsigned long flags,
> ckpt_err("checkpoint id %d\n", ret);
> }
>
> - return (ret > 0 ? 0 : 1);
> + return ret;
> }
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
More information about the Devel
mailing list