[Devel] Re: [PATCH user-cr] restart: unshare mounts ns when unsharing pidns (for --pidns)

[Oren Laadan]

Applied in ckpt-v20-dev.

Serge E. Hallyn wrote:
> NOTE - this is against Suka's latest user-cr patchset.  Without
> this patch, the cr_tests/simple testcase ends up remounting
> /proc at restart without having unshared mounts.  Therefore,
> after running the testcase no tasks show up in /proc.
> 
> With this patch on top of Suka's user-cr patchset, all cr_tests
> pass.
> 
> Signed-off-by: Serge Hallyn <serue at us.ibm.com>
> ---
>  restart.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/restart.c b/restart.c
> index 484668a..677033d 100644
> --- a/restart.c
> +++ b/restart.c
> @@ -554,7 +554,7 @@ int app_restart(struct app_restart_args *args)
>  		ret = ckpt_coordinator_pidns(&ctx);
>  	} else if (ctx.args->pidns) {
>  		ckpt_dbg("new pidns with init\n");
> -		ctx.tasks_arr[0].flags |= TASK_NEWPID;
> +		ctx.tasks_arr[0].flags |= TASK_NEWPID | TASK_NEWNS;
>  		if (global_send_sigint == -1)
>  			global_send_sigint = SIGKILL;
>  		ret = ckpt_coordinator(&ctx);
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers