[Devel] Re: [PATCH 1/2] C/R: Support for IPv6 addresses on network devices

[Brian Haley]

Dan Smith wrote:
>>> +#define HTON_IPV6(dst, src) __BYTE_ORDER_COPY(htonl, dst, src)
>>> +#define NTOH_IPV6(dst, src) __BYTE_ORDER_COPY(ntohl, dst, src)
> 
> BH> Yuck, this is ugly, use ipv6_addr_copy() please.
> 
> So, I started with ipv6_addr_copy(), but that leaves the addresses in
> the host endianess within the checkpoint image, right?  Dave Miller
> had previously asked to have the IPv4 addresses htonl()'d before being
> written to the image, so I was doing the same here.

Ok, I don't remember Dave's email.

> BH> I am still worried about this.  When an interface is activated and
> BH> the IPv6 module is loaded, it's going to generate a link-local address
> BH> right away.  Then it will auto-configure an address based on information
> BH> in a received router advertisement.  Is this code going to conflict
> BH> with that?  Meaning, will you have two link-locals on this interface
> BH> once the system is running?
> 
> I have to claim IPv6 ignorance here :)

Well, what does an 'ip -6 a' show before and after a checkpoint?

-Brian
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers