[Devel] Re: [PATCH 02/10] cr_tests: fileio: Fix do_child(i) call

[Matt Helsley]

On Mon, Mar 15, 2010 at 06:32:09PM -0500, Nathan Lynch wrote:
> On Mon, 2010-03-15 at 16:00 -0700, Matt Helsley wrote:
> > do_child() does not have an i parameter yet main calls do_child(i).
> > Clearly it's unused so just remove it.
> > 
> > Signed-off-by: Matt Helsley <matthltc at us.ibm.com>
> > ---
> >  fileio/fsetown1.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/fileio/fsetown1.c b/fileio/fsetown1.c
> > index a30e870..57f9bb6 100644
> > --- a/fileio/fsetown1.c
> > +++ b/fileio/fsetown1.c
> > @@ -226,7 +226,7 @@ int main(int argc, char *argv[])
> >  	 */
> >  	pid = fork();
> >  	if (pid == 0)
> > -		do_child(i);
> > +		do_child();
> 
> Change the definition of do_child from
> 
> void do_child()
> 
> to 
> 
> void do_child(void)
> 
> please?

Sure. I'll attach another copy of the patch with the change in a reply
to this.

> wait_for_child and setup_test_data need the same treatment.

OK.

Thanks!

Cheers,
	-Matt Helsley
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers