[Devel] Re: [PATCH 04/10] cr_tests: Add dry-run

[Matt Helsley]

On Mon, Mar 15, 2010 at 06:32:21PM -0500, Nathan Lynch wrote:
> On Mon, 2010-03-15 at 16:01 -0700, Matt Helsley wrote:
> > Make the cgroup freezer and do_ckpt() no-ops in order to do dry-runs of the
> > tests. This allows us to establish a baseline for those tests that can do
> > dry-runsi (i.e. have a dry-run option and use it to avoid restarting checkpoint
> > images).
> 
> I like this idea and I think this will be useful.
> 
> However, is there a reason we shouldn't freeze and thaw as part of the
> dry run?  I don't have strong feelings on this; just thinking we should
> try to minimize the differences in behavior and code coverage.

Well, honestly my main reason was lazyness :). Also, the goal was to make
those portions of the testcases which should be like no-ops actually be
no-ops. Then we know the test case is very likely testing the feature 
(e.g. eventfd) we want and not some prepatory step needed for checkpoint.

But your point is reasonable. We may want to know that the tests are frozen/
thawed correctly without doing checkpoint. It also probably requires fewer
changes so I think, at least as a first step I'll go with your suggestion.

Again, I'll reply with the changed patch rather than repost the series
unless someone tells me they'd prefer otherwise.

Cheers,
	-Matt Helsley
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers