[Devel] Re: [PATCH 03/12][user-cr] Add app_restart_args->debug

[Sukadev Bhattiprolu]

Serge E. Hallyn [serue at us.ibm.com] wrote:
| > @@ -583,7 +584,7 @@ static void parse_args(struct app_restart_args *args, int argc, char *argv[])
| >  			args->copy_status = 1;
| >  			break;
| >  		case 'd':
| > -			global_debug = 1;
| > +			global_debug = args->debug = 1;
| 
| You don't actually need to also set global_debug here, right?

Well, there is a subtlelty in a follow-on patch. Maybe I should move
this set of global_debug there.

global_debug is (eventually) static in both restart.c and restart-main.c
The ckpt_debug() macro defined in common.h uses the global_debug.  While
there are no callers of ckpt_debug() in restart-main.c now, setting it
here may enable us just call ckpt_debug() if necessary.

Sukadev
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers