[Devel] Re: [PATCH] user-cr: Makefile: Use standard variables

[Oren Laadan]

Applied, thanks.

Matt Helsley wrote:
> [Based on the previous series of Makefile patches]
> 
> These are standard variables which many cross compiler systems will setup.
> I believe they are also variables Make sets up with default values.
> Make also sets $(MAKE) so you don't accidentally mix make binaries in the
> same build -- let's use that too.
> 
> Signed-off-by: Matt Helsley <matthltc at us.ibm.com>
> ---
>  Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index a4a1a8a..60ddccd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -34,10 +34,10 @@ LDLIBS = -lm
>  .PHONY: all distclean clean headers install
>  
>  all: $(PROGS)
> -	@make -C test
> +	@$(MAKE) -C test
>  
>  $(LIB_ECLONE):
> -	ar ruv $(LIB_ECLONE) $^
> +	$(AR) ruv $(LIB_ECLONE) $^
>  
>  # restart needs to be thread-safe
>  restart: CFLAGS += -D__REENTRANT -pthread
> @@ -82,4 +82,4 @@ distclean: clean
>  
>  clean:
>  	@rm -f $(PROGS) $(LIB_ECLONE) $(OTHER) *~ *.o headers.h
> -	@make -C test clean
> +	@$(MAKE) -C test clean
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers