[Devel] Re: [PATCH 2/8] checkpoint: add const qualifiers to siginfo handlers

Matt Helsley matthltc at us.ibm.com
Tue Jul 13 16:29:00 PDT 2010


On Tue, Jul 13, 2010 at 10:44:18AM -0500, Nathan Lynch wrote:
> fill_siginfo and load_siginfo both have parameters that can be const.
> 
> Signed-off-by: Nathan Lynch <ntl at pobox.com>

Reviewed-by: Matt Helsley <matthltc at us.ibm.com>

> ---
>  kernel/signal.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 07647d7..13ab68e 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2913,7 +2913,7 @@ static const struct ckpt_obj_ops ckpt_obj_sighand_ops = {
>   * signal checkpoint/restart
>   */
> 
> -static void fill_siginfo(struct ckpt_siginfo *si, siginfo_t *info)
> +static void fill_siginfo(struct ckpt_siginfo *si, const siginfo_t *info)
>  {
>  	si->csi_signo = info->si_signo;
>  	si->csi_errno = info->si_errno;
> @@ -2957,7 +2957,7 @@ static void fill_siginfo(struct ckpt_siginfo *si, siginfo_t *info)
>  	}
>  }
> 
> -static int load_siginfo(siginfo_t *info, struct ckpt_siginfo *si)
> +static int load_siginfo(siginfo_t *info, const struct ckpt_siginfo *si)
>  {
>  	if (!valid_signal(si->csi_signo))
>  		return -EINVAL;
> -- 
> 1.7.1.1
> 
> _______________________________________________
> Containers mailing list
> Containers at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list