[Devel] Re: [PATCH 1/2] cgroups: Fix to return errno in a failure path

KAMEZAWA Hiroyuki kamezawa.hiroyu at jp.fujitsu.com
Tue Jan 26 16:05:31 PST 2010


On Tue, 26 Jan 2010 15:01:26 -0800
Paul Menage <menage at google.com> wrote:

> On Tue, Jan 26, 2010 at 12:16 AM, Li Zefan <lizf at cn.fujitsu.com> wrote:
> >
> > Signed-off-by: Li Zefan <lizf at cn.fujitsu.com>
> 
> Acked-by: Paul Menage <menage at google.com>
> 
Thank you.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu at jp.fujitsu.com>

> > ---
> >  cgroup.c |    7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > --- a/kernel/cgroup.c.orig      2010-01-19 16:37:37.000000000 +0800
> > +++ a/kernel/cgroup.c   2010-01-19 16:39:07.000000000 +0800
> > @@ -3279,14 +3279,17 @@ static long cgroup_create(struct cgroup
> >
> >        for_each_subsys(root, ss) {
> >                struct cgroup_subsys_state *css = ss->create(ss, cgrp);
> > +
> >                if (IS_ERR(css)) {
> >                        err = PTR_ERR(css);
> >                        goto err_destroy;
> >                }
> >                init_cgroup_css(css, ss, cgrp);
> > -               if (ss->use_id)
> > -                       if (alloc_css_id(ss, parent, cgrp))
> > +               if (ss->use_id) {
> > +                       err = alloc_css_id(ss, parent, cgrp);
> > +                       if (err)
> >                                goto err_destroy;
> > +               }
> >                /* At error, ->destroy() callback has to free assigned ID. */
> >        }
> >
> >
> 

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list