[Devel] Re: [PATCH linux-cr] x86-32 and ia32 eclone, checkpoint, restart fixes

[Sukadev Bhattiprolu]

Serge E. Hallyn [serue at us.ibm.com] wrote:
| Eclone on x86-32 should use esi for 4th arg (upids), not
| edi, which is 5th arg.  This will require a corresponding fix

Good catch and nice debug.

| to user-cr, but (a) it's correct and (b) it's required so that
| IA32_ARG_FIXUP can put upids in the right register for
| process_64.c:sys_eclone().  IA32_ARG_FIXUP will (of course) put
| edi into r8, the 5th arg.
| 
| Add the ptregs_syscall stubs for eclone, checkpoint, and restart
| for 32-bit api on x86-64.
| 
| With this patch (and proper user-cr), checkpoint and eclone work
| on x86-32, x86-64, and in 32-bit mode on x86-64.  (restart has not
| yet been tested)
| 
| Signed-off-by: Serge E. Hallyn <serue at us.ibm.com>


Reviewed-by: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers