[Devel] Re: [PATCH 1/2] nfnetlink: add netns support

[Alexey Dobriyan]

On Wed, Jan 13, 2010 at 02:27:08PM +0100, Patrick McHardy wrote:
> Alexey Dobriyan wrote:
> > On Wed, Jan 13, 2010 at 02:02:33PM +0100, Patrick McHardy wrote:
> >> Alexey Dobriyan wrote:
> > 
> >>> +	struct sock		*nfnl;
> >>> +	struct sock		*nfnl_stash;
> >> Shouldn't this be contained in an ifdef(CONFIG_NETFILTER_NETLINK)
> >> (_MODULE) ?
> > 
> > No, otherwise you won't be able to start using, e. g., nfnetlink_log
> > module on NETFILTER_NETLINK=n kernels without reboot.
> 
> You mean after enabling CONFIG_NETFILTER_NETLINK?

Yes, and it can't be directly enabled, because it's hidden option.

> That seems like a pretty poor argument, you have to do a reboot after
> changing a lot of config options.

It's still a step back if I add #ifdef and a regression if you ask me.
The price is only two pointers per-netns.
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers