[Devel] Re: [PATCH 06/12] Move checkpoint/files.c into fs/

Serge E. Hallyn serue at us.ibm.com
Fri Feb 26 08:58:21 PST 2010


Quoting Matt Helsley (matthltc at us.ibm.com):
> Subsequent patches break up fs/checkpoint.c into the file table checkpoint,
> the fs_struct checkpoint, etc.
> 
> Signed-off-by: Matt Helsley <matthltc at us.ibm.com>

The set looks good so far - it would have been nice though to do

	git mv checkpoint/files.c fs/checkpoint.c

as one separate commit, and then 'git format-patch -M'.  Then any
changes you had to make in a separate patch.  As you have it here,
I'd have to review 1050 lines of the original file line by line
against the 1050 lines in the new file...  :(

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list