[Devel] Re: [PATCH 1/2][LXC] Rename --directory option to --statefile

[Sukadev Bhattiprolu]

Daniel Lezcano [dlezcano at fr.ibm.com] wrote:
> Cedric Le Goater wrote:
>> On 02/24/2010 09:41 AM, Sukadev Bhattiprolu wrote:
>>> [See following mail for an intro to this patch set
>>>
 
>>> https://lists.linux-foundation.org/pipermail/containers/2010-February/023048.html] 
>>> 
>>>
>>>
>>> The --directory is misleading since the option seems to expect
>>> an checkpoint image file.
>>  sigh.
>>
>> This has some major impact on our side as it is a 9 year old API ...
>> We'll look into it to see how painful it is to change.

Ah, did not realize it caused that much pain.

>
> We can keep --directory and add --statefile.
> For --statefile option we can use a switch for IS_DIR, IS_REG.
>
> --directory becomes deprecated and we switch to the statefile option  
> step by step.
>
> Does it make sense ?

Yes, I think it will work.

BTW, what was the rationale for a directory ?  Is it meant to be used
with predefined file names in the specified directory ?

>
>   -- Daniel
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers