[Devel] Re: [PATCH -mmotm] cgroup: fix typo in error handling in cgroup_write_event_control()

[Paul Menage]

On Wed, Feb 24, 2010 at 5:31 AM, Kirill A. Shutemov
<kirill at shutemov.name> wrote:
> Actually, we want to fput() cfile, if cfile is not NULL.
>
> Signed-off-by: Kirill A. Shutemov <kirill at shutemov.name>

Thanks.

Acked-by: Paul Menage <menage at google.com>

> ---
>  kernel/cgroup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index d142524..049ce0d 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -3117,7 +3117,7 @@ static int cgroup_write_event_control(struct cgroup *cgrp, struct cftype *cft,
>        return 0;
>
>  fail:
> -       if (!cfile)
> +       if (cfile)
>                fput(cfile);
>
>        if (event && event->eventfd && !IS_ERR(event->eventfd))
> --
> 1.6.6.2
>
>
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers