[Devel] Re: [PATCH -mm] cgroups: fix failure path in cgroup_write_event_control()

[Kirill A. Shutemov]

On Wed, Feb 24, 2010 at 5:22 AM, Li Zefan <lizf at cn.fujitsu.com> wrote:
> How to reproduce:
>
>  # mount -t cgroup -o memory xxx /cgroup
>  # mkdir /cgroup/tmp
>  # ./cgroup_event_listener /cgroup/tmp/cgroup.event_control abc
>  ^C
>  # rmdir /cgroup/tmp
>  # cat /proc/cgroups | grep memory
>  memory  2       2       1         (should be "2 1 1")
>  # umount /cgroup
>  (failed!)
>
> Using a single goto label to cleanup multi failure paths can
> get things wrong quite easily, while multi labels makes the
> code cleaner.

I disagree.
It's easer to make mistake on changing code with multi failure
paths, if you want to move a code within function.
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers