[Devel] Re: [PATCH v2 -mmotm 2/4] cgroups: remove events before destroying subsystem state objects

[Kirill A. Shutemov]

On Wed, Feb 24, 2010 at 10:40 AM, Balbir Singh
<balbir at linux.vnet.ibm.com> wrote:
> * Kirill A. Shutemov <kirill at shutemov.name> [2010-02-22 17:43:40]:
>
>> Events should be removed after rmdir of cgroup directory, but before
>> destroying subsystem state objects. Let's take reference to cgroup
>> directory dentry to do that.
>>
>> Signed-off-by: Kirill A. Shutemov <kirill at shutemov.name>
>> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hioryu at jp.fujitsu.com>
>
> Looks good, but remember the mem_cgroup data structure will can
> disappear after the rmdir

IIUC, struct mem_cgroup can be freed only after ->destroy(), which can
be called only if there is no references to cgroup directory dentry.

Have I missed something?
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers