[Devel] Re: [PATCH][user-cr]: ckptinfo: Have -v imply -p option

[Oren Laadan]

Sukadev Bhattiprolu wrote:
> Do we even need the -p option ? It is not used without the -v at present.
> Can we drop the -p and have -v print filepos always ?

Ok.  I'll do that.

Oren.

> 
> ---
> From: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
> Date: Fri, 19 Feb 2010 11:19:08 -0800
> Subject: [PATCH 1/1] ckptinfo: Have -v imply -p
> 
> When the -v is chosen, user wants verbose debug information. The
> filepos would be useful to correlate with the kernel debug messages
> and does not clutter the output.
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
> ---
>  ckptinfo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ckptinfo.c b/ckptinfo.c
> index 6859742..be91b80 100644
> --- a/ckptinfo.c
> +++ b/ckptinfo.c
> @@ -135,7 +135,7 @@ int main(int argc, char *argv[])
>  
>  	if (args.verbose)
>  		__verbose = 1;
> -	if (args.position)
> +	if (args.position || args.verbose)
>  		__position = 1;
>  
>  	argc -= optind;
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers