[Devel] Re: [PATCH 5/9] use ckpt_err for architecture mismatch errors

[Serge E. Hallyn]

Quoting Oren Laadan (orenl at cs.columbia.edu):
> 
> 
> serue at us.ibm.com wrote:
> > From: Serge E. Hallyn <serue at us.ibm.com>
> > 
> > Signed-off-by: Serge E. Hallyn <serue at us.ibm.com>
> > ---
> >  arch/x86/kernel/checkpoint.c |    4 +++-
> >  checkpoint/restart.c         |   18 ++++++++++++++----
> >  2 files changed, 17 insertions(+), 5 deletions(-)
> > 
> 
> [...]
> 
> > diff --git a/checkpoint/restart.c b/checkpoint/restart.c
> > index fcd07fa..9bb17fc 100644
> > --- a/checkpoint/restart.c
> > +++ b/checkpoint/restart.c
> > @@ -569,12 +569,14 @@ static int check_kernel_const(struct ckpt_const *h)
> >  		return -EINVAL;
> >  	if (h->uts_nodename_len != sizeof(uts->nodename))
> >  		return -EINVAL;
> > +#if 0
> >  	if (h->uts_release_len != sizeof(uts->release))
> >  		return -EINVAL;
> >  	if (h->uts_version_len != sizeof(uts->version))
> >  		return -EINVAL;
> >  	if (h->uts_machine_len != sizeof(uts->machine))
> >  		return -EINVAL;
> > +#endif
> 
> What is the purpose of this ?  I thought these sizes do not
> depends on the kernel bit-ness.

Jinkeys - yeah that shouldn't be there.

> >  	if (h->uts_domainname_len != sizeof(uts->domainname))
> >  		return -EINVAL;
> >  	/* rlimit */
> 
> [...]
> 
> Oren.
> 
> _______________________________________________
> Containers mailing list
> Containers at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers