[Devel] Re: [PATCH v5 3/3] cgroups: make procs file writable

[David Rientjes]

On Sun, 26 Dec 2010, Ben Blum wrote:

> I was going to make a macro like NODEMASK_STATIC, but it turned out that
> can_attach() needed the to/from nodemasks to be shared among three
> functions for the attaching, so I defined them globally without making a
> macro for it.

I'm not sure what the benefit of defining it as a macro would be.  You're 
defining these statically allocated nodemasks so they have file scope, I 
hope (so they can be shared amongst the users who synchronize on 
cgroup_lock() already).

> I can make a separate patch for fixing the other cases,
> but I'd like to see my current patches through first. (Or should I make
> a bugfix patch first and send my other ones on top of that?)
> 

I don't think the fix is urgent since the NODEMASK_ALLOC()'s have been 
around since March and nobody has complained about the failures, I 
personally wouldn't delay your own development over something you've found 
only through code inspection.  I think it's safe to defer to afterwards.
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers