[Devel] Re: [PATCH v5 3/3] cgroups: make procs file writable

Andrew Morton akpm at linux-foundation.org
Fri Dec 24 03:53:31 PST 2010


On Fri, 24 Dec 2010 06:45:00 -0500 Ben Blum <bblum at andrew.cmu.edu> wrote:

> > kmalloc() is allowed while holding a spinlock and NODEMASK_ALLOC() takes a 
> > gfp_flags argument for that reason.
> 
> Ah, it's only with GFP_KERNEL and friends. So changing the uses in
> cpuset_can_attach to GFP_ATOMIC would solve this concern, then?

It would introduce an additional concern.  GFP_ATOMIC is bad, for a
number of reasons.  The main one of which is that it is vastly less
reliable than GFP_KERNEL.  And making the cpuset code less reliable
is a regression, no?

Please try to find a better solution.
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list