[Devel] Re: [RFC][PATCH 0/6][usercr]: Rename/reorg usercr code

[Oren Laadan]

Sukadev Bhattiprolu wrote:
> Oren Laadan [orenl at cs.columbia.edu] wrote:
>> Hi Suka,
>>
>> Thanks for the patchset. A couple of comments:
>>
>> * I prefer the header exported to users to be checkpoint.h - this
>> is consistent with kernel headers, and with future name of a c/r
>> library if we opt libcheckpoint.a
> 
> That is fine. Will this checkpoint.h include <linux/checkpoint.h> ?

Definitely.

> 
>> * I also prefer to leave checkpoint.c as a separate file, as is.
>> It may gain more functionality in the future. If the goal was to
>> only export a single .o file, then the solution IMHO is to instead
>> export a single library: libcheckpoint.a
> 
> A single .o was not really a goal. Sure, if we are ready for libcheckpoint.a
> then thats a better way.
> 
>> Unless you have a strong opinion against the above, I'll go ahead
>> and pull patches 1-3, leave out 4-6, and update the Makefile to
>> create a libcheckpoint.a library.
> 
> How about patch 6, renaming 'common.h' to 'cr_log.h' (file internal to
> usercr) ? Let me know if you want me to resend the patches dropping 4 and 5.

It's not strictly limited to logging affairs, and it may have more
in the future, so I'd rather keep it as is.

No need to resend. I'll just pull and edit.

Thanks!

Oren.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers