[Devel] Re: [PATCH 3/4] Add IPv6 address checkpoint handler

Dan Smith danms at us.ibm.com
Fri Apr 16 08:02:24 PDT 2010


BH> Yes, and I just realized something else.  This code:

BH> +	ret = inet6_addr_add(net, dev->ifindex, &addr->inet6_addr,
BH> +			     addr->inet6_prefix_len, IFA_F_PERMANENT,
BH> +			     INFINITY_LIFE_TIME, INFINITY_LIFE_TIME);

BH> isn't using the saved lifetimes either, so it won't ever go away.

I again have to plead ignorance here.  Do permanent addresses ever
have anything other than INFINITY_LIFE_TIME?  Assuming not, I think
it's reasonable (for now, at least) to stick to (correctly) saving and
restoring the permanent addresses.  What do you think?

-- 
Dan Smith
IBM Linux Technology Center
email: danms at us.ibm.com
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list