[Devel] Re: [PATCH 3/4] Add IPv6 address checkpoint handler

[Brian Haley]

Dan Smith wrote:
> +static int inet6_restore(struct ckpt_ctx *ctx,
> +			 struct net_device *dev,
> +			 struct net *net,
> +			 struct ckpt_netdev_addr *addr)
> +{
> +	int ret;
> +
> +	rtnl_lock();
> +	ret = inet6_addr_add(net, dev->ifindex, &addr->inet6_addr,
> +			     addr->inet6_prefix_len, IFA_F_PERMANENT,
> +			     INFINITY_LIFE_TIME, INFINITY_LIFE_TIME);
> +	rtnl_unlock();

Is using IFA_F_PERMANENT correct here?  Should you save the flags from
the address when checkpointing?  Permanent means it was added by the
user, not by the kernel, so you could be changing things slightly.

-Brian
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers