[Devel] Re: [PATCH linux-cr] cr: fs/inode.c: make sure ckpt_obj_register() actually runs

[Matt Helsley]

On Tue, Apr 13, 2010 at 05:09:31PM -0500, Serge E. Hallyn wrote:
> Quoting Matt Helsley (matthltc at us.ibm.com):
> > On Tue, Apr 13, 2010 at 03:35:35PM -0500, Serge E. Hallyn wrote:
> > > [ This is against Matt's code-shuffled patchset ]
> > > 
> > > So put it in its own, explicitly-called init function.
> > 
> > I did not spot the early return from inode_init(). So an alternate
> > fix is to move the #ifdef CONFIG_CHECKPOINT block up before
> > this early return:
> > 
> >         /* Hash may have been set up in inode_init_early */
> >         if (!hashdist)
> >                 return;
> > 
> > hashdist is set to HASHDIST_DEFAULT which is probably different on
> > s390 from x86-32/64. At least that would explain why this wasn't
> > spotted in my earlier testing.
> 
> Right, my x86-64 tests all passed last night too...
> 
> Anyway I still prefer it be in its own init function, but whatever

Yeah, I think there are a few advantages your approach:

1) Stays inside one #ifdef CONFIG_CHECKPOINT nicely
2) Happens at device init callback time -- we don't need to plug into early
	boot
3) Is obviously not dependent on the inode cache initialization code this way
...

> works.  You have it moved up now in your set?  When oren posts a new
> tree I'll be sure to test that.

I'll fold your patch into my set and Oren can let me know what he wants
to do.

Cheers,
	-Matt Helsley
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers