[Devel] Re: [PATCH 2/2] Add checkpoint/restart support for epoll files.

[Oren Laadan]

Oren Laadan wrote:
> 
> Matt Helsley wrote:
>> Save/restore epoll items during checkpoint/restart respectively.
>> kmalloc failures should be dealt with more kindly than just error-out
>> because epoll is made to poll many thousands of file descriptors.
>> Subsequent patches will change epoll c/r to "chunk" its output/input
>> respectively.
> 
> [...]
> 
>>  
>> @@ -311,9 +313,11 @@ static int do_checkpoint_file_table(struct ckpt_ctx *ctx,
>>  	}
>>  
>>  	ret = deferqueue_run(ctx->files_deferq);
>> -	ckpt_debug("files_deferq ran %d entries\n", ret);
>> -	if (ret > 0)
>> +	if (ret > 0) {
>> +		ckpt_debug("file checkpoint deferred %d work items\n", ret);
>>  		ret = 0;
>> +	}
>> +
> 
> With your permission, I'll do this hunk as a separate patch (and
> the restore counterpart too). So you can remove from your patch.

I take that back. I prefer the previous debug, that give info
whether the call succeeded or not...

Oren.

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers