[Devel] Re: [PATCH 01/17] ckpt_write_err: use single format with %(T) style tokens

[Serge E. Hallyn]

Quoting Sukadev Bhattiprolu (sukadev at linux.vnet.ibm.com):
> serue at us.ibm.com [serue at us.ibm.com] wrote:
> | From: Serge E. Hallyn <serue at us.ibm.com>
> | 
> | Matt Helsley originally suggested this to avoid having two
> | format strings.  This is not bisect-safe and therefore not
> | even compile-tested.  Every call to ckpt_write_err must be
> | updated to use a single format.
> 
> It maybe easier to review this patch if this is broken up into smaller
> patches:
> 
> 	- move the code to new place
> 	- leave the fmt0 parameter to ckpt_generate_fmt() but ensure it
> 	  is unused.
> 	- finally remove the unused parameters from ckpt_generate_fmt()
> 	  and the callers. 

That's going a bit far...  I did leave the moving of the code in a separate
patch up until this last posting, but the new and old versions of
ckpt_generate_fmt() don't look alike enough to be able to compare side by
side anyway imo.

One thing which would help however imo would be if I keep a non-rebased
tagged tree alongside the rebased tree, so you can see what changes I'm
making over the last posting.  I'll do that as of today.

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers