[Devel] Re: [PATCH 1/2] [RFC] Add file f_flags to cgroup write_string ops

Paul Menage menage at google.com
Tue Oct 27 23:04:42 PDT 2009


On Tue, Oct 27, 2009 at 6:04 PM, Li Zefan <lizf at cn.fujitsu.com> wrote:
>
> I think maybe it's better to store struct file *file to struct cftype,
> so we don't need to change write_string(), write(), write_u64()
> and write_s64().

We can't do that - multiple open files could be using the same cftype
at the same time. I'd be inclined if necessary to just pass the struct
file* in, rather than risk needing to change it to pass more
parameters later.

Paul
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list