[Devel] Re: [PATCH user-cr] Allow for logfile for kernel debug messages (v2)

[Serge E. Hallyn]

Quoting Oren Laadan (orenl at librato.com):
> 
> Serge E. Hallyn wrote:
> > If unspecified, -1 will be sent for logfd to the kernel, and there
> > will be no debug log.   If specified, then checkpoint and restart
> > debug msgs will be sent to the logfile.
> 
> The new interface will cover error reporting, so when run without '-l'

Not sure what you mean by 'the new interface will cover error reporting'.

> both 'checkpoint' and 'restart' (unless asked to run extra silently)
> need to provide a pipe to the syscall, and if an error occurs, display
> pull the error reason from the pipe and print it.

Sounds like a useful feature, but to be clear note that what is now
ckpt_err() output from the kernel was debug output before, so compared
to without this patchset, the user is not losing any information.

In fact what you're saying sounds like even more justification for
changing some of the

	ret = abc();
	ckpt_debug("...", ret);
	if (!ret)
		ret = cdef();
	ckpt_debug("...", ret);

type of flow into one where ckpt_err() is used and only in the case of
a definite error.  Yes?

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers