[Devel] Re: [PATCH 1/2] Add socket list helper functions

[Serge E. Hallyn]

Quoting Dan Smith (danms at us.ibm.com):
> OL> IMHO this is over-engineered. This way, you place net-related
> OL> knowledge in ckpt_ctx_free(), instead of isolating that sort of
> OL> smarts under net/ subdir. I'd rather see the clean-up logic near
> OL> the "litter" logic, so to speak.
> 
> Well, I still need to clean up the list after the deferqueue has run,
> so something has to go into ckpt_ctx_free() to do that.  I can make it
> a specific call like ckpt_sock_cleanup_listening() or something, but
> that will still need to go in checkpoint.h so I can call it from
> ctx_free()...

Heh, but that sounds like over-engineering  :)

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers