[Devel] Re: [PATCH] Remove an unnecessary check on socket restart

[Serge E. Hallyn]

Quoting Dan Smith (danms at us.ibm.com):
> This check is removed because it cannot be true because of the
> unsigned nature of the value being examined.
> 
> Signed-off-by: Dan Smith <danms at us.ibm.com>

Thanks.  I actually do keep missing real errors bc of the
noise (most of which comes from cred.h :( ), so I appreciate
every bit they can be reduced.

Acked-by: Serge Hallyn <serue at us.ibm.com>


> Cc: serue at us.ibm.com
> Cc: orenl at librato.com
> ---
>  net/checkpoint.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/checkpoint.c b/net/checkpoint.c
> index a11ec7a..0087a8a 100644
> --- a/net/checkpoint.c
> +++ b/net/checkpoint.c
> @@ -484,8 +484,7 @@ static int sock_cptrst(struct ckpt_ctx *ctx, struct sock *sk,
>  		   (h->sock.state >= TCP_MAX_STATES)) {
>  		ckpt_debug("sock in invalid state: %i", h->sock.state);
>  		return -EINVAL;
> -	} else if ((h->socket.state < SS_FREE) ||
> -		   (h->socket.state > SS_DISCONNECTING)) {
> +	} else if (h->socket.state > SS_DISCONNECTING) {
>  		ckpt_debug("socket in invalid state: %i",
>  			   h->socket.state);
>  		return -EINVAL;
> -- 
> 1.6.0.4
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers