[Devel] Re: [PATCH] [RFC] checkpoint/restart timerfd

[Matt Helsley]

On Mon, Nov 16, 2009 at 01:56:03PM -0500, Oren Laadan wrote:

<snip>

> > diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h
> > index dfcb59b..f429386 100644
> > --- a/include/linux/checkpoint.h
> > +++ b/include/linux/checkpoint.h
> > @@ -321,6 +321,17 @@ static inline int ckpt_validate_errno(int errno)
> >  			memcpy(LIVE, SAVE, count * sizeof(*SAVE));	\
> >  	} while (0)
> >  
> > +struct ckpt_itimerspec;
> > +struct itimerspec;
> > +static inline void ckpt_copy_itimerspec(int op, struct ckpt_itimerspec *h,
> > +					struct itimerspec *tmr)
> > +{
> > +	CKPT_COPY(op, h->interval.tv_sec,  tmr->it_interval.tv_sec);
> > +	CKPT_COPY(op, h->interval.tv_nsec, tmr->it_interval.tv_nsec);
> > +	CKPT_COPY(op, h->value.tv_sec,     tmr->it_value.tv_sec);
> > +	CKPT_COPY(op, h->value.tv_nsec,    tmr->it_value.tv_nsec);
> > +}
> > +
> 
> Is there a reason to place this here and not in timerfd source file ?

I hadn't checked the code in checkpoint/signal.c -- I was hoping to share the
itimerspec struct but clearly it's not needed there. I'll move it to timerfd.c.

Thanks for the review!

Cheers,
	-Matt
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers