[Devel] Re: [PATCH user-cr 2/2] add nsexeccwp to test clone-with-pids

Serge E. Hallyn serue at us.ibm.com
Fri Nov 13 13:08:18 PST 2009


Quoting serue at us.ibm.com (serue at us.ibm.com):
...
> +		pid = clone_with_pids(do_child, stack, flags, &pid_set,
> +					(void *)argv);
> +		if (pid == -1) {
> +			perror("clone");
> +			return -1;
> +		}

Come on Serge, what crapppy code!  The clone_with_pids() wrapper used
in user-cr doesn't set errno, so this is messed up on failure.  Shape
up!

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers




More information about the Devel mailing list