[Devel] Re: [PATCH 04/22] Change to the new enhanced error string format

[Matt Helsley]

On Mon, Nov 02, 2009 at 10:52:20AM -0600, Serge E. Hallyn wrote:
> Quoting Matt Helsley (matthltc at us.ibm.com):
> > On Fri, Oct 30, 2009 at 06:00:26PM -0500, serue at us.ibm.com wrote:
> > > From: Serge E. Hallyn <serue at us.ibm.com>
> > > 
> > > Signed-off-by: Serge E. Hallyn <serue at us.ibm.com>
> > > ---

<snip>

> ...
> 
> > > +		default:
> > > +			printk(KERN_ERR "c/r: bad format specifier %c\n",
> > > +					fmt[2]);
> > > +			BUG();
> > 
> > Perhaps BUG() isn't such a good idea since this will be used in
> 
> I disagree - this fmt is passed in by the kernel, so if we get a flag
> we don't understand, then it is a bug in our c/r code.

OK, you've convinced me.

Cheers,
	-Matt Helsley

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers