[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

[jamal]

Thanks for the CC Jarek.

On Fri, 2009-05-29 at 10:22 +0000, Jarek Poplawski wrote:

> > > I didn't verify this too much, so I might be wrong, but it looks like
> > > cls_cgroup_classify() does things a bit different than others (doesn't
> > > check the 'head' etc. for NULL), so maybe you should consider fixing
> > > it instead? (Btw., the tc classifier maintainer added to Cc).
> > 
> > OOPS! Others mostly don't check this either, so my suggestion was wrong.
> 
> Hmm... Or maybe I wasn't so wrong; it seems classifiers which
> don't assign the head during init do this check for NULL later.

It is good practise to initialize things in init() and use attributes
in change() to set them. 
I will read the thread and check out the code path then respond
more intelligently.

cheers,
jamal

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers