[Devel] Re: [PATCH 06/38] ipcns 4/2: move free_ipcs() proto

[Serge E. Hallyn]

Quoting Alexey Dobriyan (adobriyan at gmail.com):
> Function is really private to ipc/ and avoid struct kern_ipc_perm
> forward declaration.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan at gmail.com>

Reviewed-by: Serge Hallyn <serue at us.ibm.com>

> ---
>  include/linux/ipc_namespace.h |    4 ----
>  ipc/util.h                    |    3 ++-
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/ipc_namespace.h b/include/linux/ipc_namespace.h
> index 804e4e4..e408722 100644
> --- a/include/linux/ipc_namespace.h
> +++ b/include/linux/ipc_namespace.h
> @@ -96,10 +96,6 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
>  #if defined(CONFIG_IPC_NS)
>  extern struct ipc_namespace *copy_ipcs(unsigned long flags,
>  				       struct ipc_namespace *ns);
> -extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
> -		      void (*free)(struct ipc_namespace *,
> -				   struct kern_ipc_perm *));
> -
>  static inline struct ipc_namespace *get_ipc_ns(struct ipc_namespace *ns)
>  {
>  	if (ns)
> diff --git a/ipc/util.h b/ipc/util.h
> index 1187332..7a2861b 100644
> --- a/ipc/util.h
> +++ b/ipc/util.h
> @@ -171,5 +171,6 @@ static inline void ipc_unlock(struct kern_ipc_perm *perm)
>  struct kern_ipc_perm *ipc_lock_check(struct ipc_ids *ids, int id);
>  int ipcget(struct ipc_namespace *ns, struct ipc_ids *ids,
>  			struct ipc_ops *ops, struct ipc_params *params);
> -
> +void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
> +		void (*free)(struct ipc_namespace *, struct kern_ipc_perm *));
>  #endif
> -- 
> 1.5.6.5
> 
> _______________________________________________
> Containers mailing list
> Containers at lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers