[Devel] Re: [PATCH] cgroups: handle failure of cgroup_populate_dir() at mount/remount

[KAMEZAWA Hiroyuki]

On Fri, 22 May 2009 16:35:14 +0800
Li Zefan <lizf at cn.fujitsu.com> wrote:

> KAMEZAWA Hiroyuki wrote:
> > On Fri, 22 May 2009 11:00:12 +0800
> > Li Zefan <lizf at cn.fujitsu.com> wrote:
> > 
> >> Now we have 'stat' file in both memory and cpuacct subsystems. If we
> >> mount these 2 subsystems with option 'noprefix', the creation of 'stat'
> >> file for cpuacct will fail, but without any notificatin to the user.
> >>
> >> With this patch, we fail the mount/remount in this case.
> >>
> > 
> > Hm, shouldn't we allow "noprefix" to be effective only agaisnt cpuset ?
> > I think it's just for backward-compatibility of cpuset.
> > (I don't like the option at all.)
> > 
> 
> Yes, this mount option was introduced for cpuset. But it has been here for
> a long time and people may use it when mounting other cgroup subsystems,
> then is it OK to change to restrict its use within cpuset only?

Asking libcgroup people may be appropriate...added CC.

Thanks,
-Kame

_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers