[Devel] Re: [PATCH 4/6] cr: checkpoint and restore task credentials

[Serge E. Hallyn]

Quoting Oren Laadan (orenl at cs.columbia.edu):
> >  /* read the task_struct into the current task */
> > -static int restore_task_struct(struct ckpt_ctx *ctx)
> > +static int restore_task_struct(struct ckpt_ctx *ctx, struct cred **realcredp,
> > +				struct cred **ecredp)
> 
> 				^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
> 				
> This probably belongs to restore_task_shared() ?

Why?  The task->cred and task->ecred are task properties, so
their reference should be stored in the ckpt_hdr_task->cred_ref
and ckpt_hdr_task->ecred_ref, no?

-serge
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers