[Devel] Re: [PATCH] Remove READ_IMPLIES_EXEC during restart

[Oren Laadan]

Dan,

Now after the rework of the patchset, it's probably a good time
to add support for this.

I'm unsure if the personality can affect other restore actions
that take place elsewhere If so, probably the correct way is to:

1) restore personality as part of the task (in the beginning)

2) temporarily change it around those places where we want the
"native" personality, e.g. the call to do_mmap_pgoff(), or shmat(),

(The reason not to put it around the entire restore_mm() is to
be safe in case a personality makes a difference when you open
files. This way we isolate the effect of changing personality).

Any thoughts ?

Oren.

Dan Smith wrote:
> OL> In fact, if elsewhere we restore current->personality of the task,
> OL> then unless we move it to cr_read_mm(), it will overwrite it :(
> 
> Should we move it or just remove RIE before we start the restart and
> let the task regain the flag if it had it before?
> 
_______________________________________________
Containers mailing list
Containers at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers